feat: run snapshot tests dynamically in unimarkup-core crate (#105)

* fix: move functions for dynamic testing to test_runner

* fix: remove unused test from core crate

* fix: use macro to generate path to crate's integration tests folder

* fix: run core snap tests dynamically using custom test harness

* fix: correct documentation for test_runner helper functions

* fix: format code

* fix: auto-fix linter issues

* fix: use array of custom tests instead of vec

* fix: use resolver v2 for workspace

* fix: update icu to resolve incompatibilities

* fix: snapshot test blocks and provide better snapshot info

* fix: rename core snapshot testing function

* fix: remove dbg! call

* fix: use better name to indicate clone of variable

Cargo.toml

@@ -7,6 +7,7 @@ members = [
     "parser",
     "render",
 ]
+resolver = "2"
 
 # Compile snapshot testing library "insta" with "release" flag so that it runs
 # faster

commons/Cargo.toml

@@ -19,12 +19,10 @@ serde.workspace = true
 serde_json.workspace = true
 serde_yaml.workspace = true
 once_cell = { workspace = true, optional = true }
-icu = "=1.2.0"
-zerovec = "0.9.4"
-icu_provider = "=1.2.0"
-icu_provider_adapters = "=1.2.0"
+icu_segmenter = "1.3.0"
+icu_locid = "1.3.0"
 regex = { version = "1.8.1", optional = true }
-insta = {version = "1.29.0", features = ["serde"], optional = true}
+insta = { version = "1.29.0", features = ["serde"], optional = true }
 
 [features]
 test_runner = ["dep:regex", "dep:once_cell", "dep:insta"]

commons/src/config/locale.rs

@@ -1,5 +1,5 @@
 pub mod serde {
-    use icu::locid::Locale;
+    use icu_locid::Locale;
     use serde::{Deserialize, Deserializer, Serializer};
 
     pub mod single {
@@ -70,7 +70,7 @@ pub mod serde {
 }
 
 pub mod clap {
-    pub fn parse_locale(input: &str) -> Result<icu::locid::Locale, clap::Error> {
+    pub fn parse_locale(input: &str) -> Result<icu_locid::Locale, clap::Error> {
         input.parse().map_err(|err| {
             clap::Error::raw(
                 clap::error::ErrorKind::InvalidValue,

commons/src/config/mod.rs

@@ -1,12 +1,12 @@
 use std::{collections::HashSet, path::PathBuf};
 
-use clap::{crate_authors, Args, Parser};
+use clap::{Args, Parser};
 use logid::err;
 use serde::{Deserialize, Serialize};
 
 use self::{log_id::ConfigErr, output::Output, preamble::Preamble};
 
-pub use icu::locid;
+pub use icu_locid;
 
 pub mod locale;
 pub mod log_id;
@@ -43,7 +43,7 @@ pub trait ConfigFns {
 }
 
 #[derive(Parser, Debug, PartialEq, Eq, Clone, Default, Serialize, Deserialize)]
-#[command(name = UNIMARKUP_NAME, help_template = HELP_TEMPLATE, author = crate_authors!(", "), version, about = ABOUT, long_about = None)]
+#[command(name = UNIMARKUP_NAME, help_template = HELP_TEMPLATE, author, version, about = ABOUT, long_about = None)]
 pub struct Config {
     #[command(flatten)]
     pub preamble: Preamble,
@@ -112,7 +112,7 @@ where
             format!("HashSet conversion failed with: {:?}", err),
         )
     });
-    Ok(HashSet::from_iter(entries?.into_iter()))
+    Ok(HashSet::from_iter(entries?))
 }
 
 // Define extension trait

commons/src/config/preamble.rs

@@ -4,7 +4,7 @@ use std::{
 };
 
 use clap::Args;
-use icu::locid::Locale;
+use icu_locid::Locale;
 use logid::err;
 use serde::{Deserialize, Serialize};
 
@@ -55,7 +55,7 @@ pub struct I18n {
 
 impl ConfigFns for I18n {
     fn merge(&mut self, other: Self) {
-        self.output_langs.extend(other.output_langs.into_iter());
+        self.output_langs.extend(other.output_langs);
     }
 
     fn validate(&self) -> Result<(), ConfigErr> {
@@ -79,8 +79,8 @@ pub struct RenderConfig {
 
 impl ConfigFns for RenderConfig {
     fn merge(&mut self, other: Self) {
-        self.ignore.extend(other.ignore.into_iter());
-        self.parameter.extend(other.parameter.into_iter());
+        self.ignore.extend(other.ignore);
+        self.parameter.extend(other.parameter);
     }
 
     fn validate(&self) -> Result<(), ConfigErr> {
@@ -103,7 +103,7 @@ pub struct Citedata {
 impl ConfigFns for Citedata {
     fn merge(&mut self, other: Self) {
         self.style.replace_none(other.style);
-        self.references.extend(other.references.into_iter());
+        self.references.extend(other.references);
     }
 
     fn validate(&self) -> Result<(), ConfigErr> {
@@ -146,8 +146,8 @@ pub struct Metadata {
 impl ConfigFns for Metadata {
     fn merge(&mut self, other: Self) {
         self.title.replace_none(other.title);
-        self.authors.extend(other.authors.into_iter());
-        self.fonts.extend(other.fonts.into_iter());
+        self.authors.extend(other.authors);
+        self.fonts.extend(other.fonts);
 
         // Note: `base` and `description` must not be merged with sub-configs according to specification.
     }
@@ -184,8 +184,8 @@ pub struct HtmlSpecificParameter {
 
 impl ConfigFns for HtmlSpecificParameter {
     fn merge(&mut self, other: Self) {
-        self.favicons.extend(other.favicons.into_iter());
-        self.keywords.extend(other.keywords.into_iter());
+        self.favicons.extend(other.favicons);
+        self.keywords.extend(other.keywords);
     }
 
     fn validate(&self) -> Result<(), ConfigErr> {