-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pdf support #114
Pdf support #114
Conversation
Converting
The PDF is correctly generated, but I guess headless chromium fails at cleanup? |
This Bug is known in headless-chrome: rust-headless-chrome/rust-headless-chrome#441 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for the initial pdf support.
The CloseFrame
error is fixed in the main branch of headless chromium, but this version is not yet published.
We internally agreed to wait for the official release, because the pdf is rendered correctly already anyways.
Enable pdf as command line flag for
--output-formats
and render the html-document to a pretty printed pdf