- 
                Notifications
    You must be signed in to change notification settings 
- Fork 285
generalize upgrade to take more than one lib pair simultaneously #5963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Nice! Could you explain the different cases with the different messages; I guess when there's underscores in the arg names, then it doesn't try to "rename", and then under certain circumstances it does? And then I think we should probably not have a bulleted list with just one bullet. | 
| Regarding renaming, it's the same behavior as before - if the library you are upgrading to ends in   | 
| 
 Ok, I just replaced it with a comma-separated list then, like in the successful upgrade message | 
Overview
This PR generalizes
upgradeto allow upgrading multiple libraries simultaneously:(it's an error to provide an odd number of arguments).
One small user-visible implementation quirk: if an upgrade fails, we had been putting the user on a branch called
upgrade-<old>-to-<new>to resolve it, as a reminder about the branch context. However, I didn't want to continue that template for an arbitrary number of library upgrades, so if a 2+ library upgrade fails, the user is just put on a branch calledupgrade(orupgrade__2ifupgradeis taken, etc).Test coverage
I've added tests to the
upgrade.mdtranscript.