-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding QEM schema directory #2597
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2597 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 92 92
Lines 4174 4183 +9
=======================================
+ Hits 4121 4130 +9
Misses 53 53 ☔ View full report in Codecov by Sentry. |
Thanks for adding this here Ella! Good start. We'll need to pair this down quite a bit before merging it in. For the time being, lets just add the schemas, and the code to validate experiments for the techniques you've already completed. Then we can make sure to add tests, ensure the code is formatted correctly, etc. Baby steps help us build up confidence about new code! |
Description
Resolves issue #2586
Added directory mitiq/schema containing @ruheenirodi and I's current work developing QEM schema.
A lot of this work (all) is not finalized, so let us know if we should instead just start with an empty directory and only add work that is fully-developed.
License
Before opening the PR, please ensure you have completed the following where appropriate.