Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Avalonia and other NuGet packages #225

Merged
merged 10 commits into from
Feb 8, 2024

Conversation

CorruptComputer
Copy link
Contributor

@CorruptComputer CorruptComputer commented Dec 25, 2023

Should be ready now, also adds a pop-up window for when the code scan fails.

image

@corp-0
Copy link
Member

corp-0 commented Dec 25, 2023

Does this depend on the other PR updating dotnet?

@CorruptComputer
Copy link
Contributor Author

No it doesn't, I kept it at 7.0 for these changes

@corp-0
Copy link
Member

corp-0 commented Dec 25, 2023

How is the new version of Avalonia related to upgrading dotnet then?

Do we really need to update Avalonia?

@CorruptComputer
Copy link
Contributor Author

The warning here: https://github.com/unitystation/stationhub/actions/runs/7316971571/job/19932278559?pr=224#step:5:10

Warning: /usr/share/dotnet/sdk/8.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(284,5): warning NETSDK1206: Found version-specific or distribution-specific runtime identifier(s): win7-x64, win7-x86. Affected libraries: Avalonia.Angle.Windows.Natives. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details. [/home/runner/work/stationhub/stationhub/UnitystationLauncher/UnitystationLauncher.csproj]

@corp-0
Copy link
Member

corp-0 commented Feb 8, 2024

it is not the prettiest popup ever, but it is serviceable. Thanks

@corp-0 corp-0 merged commit 70af956 into unitystation:develop Feb 8, 2024
5 of 6 checks passed
@CorruptComputer CorruptComputer deleted the avalonia-11-upgrade branch February 9, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants