Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3DS enable/disable routes #1221

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

phieronymus
Copy link
Collaborator

@phieronymus phieronymus added the Enhancement New feature or request label Dec 6, 2024
@phieronymus phieronymus requested a review from gdp88 December 6, 2024 05:51
@coveralls
Copy link

coveralls commented Dec 6, 2024

Coverage Status

coverage: 98.755% (+0.003%) from 98.752%
when pulling a5fbd9f on feature/pierreh/add-three-ds-enable-and-disable
into 13405d3 on master.

return this._enableThreeDs(null, auth, { storeId, tokenId: id });
}

private _disablehreeDs?: DefinedRoute;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "T" was eaten

@gdp88
Copy link
Collaborator

gdp88 commented Dec 6, 2024

Just a typo..lgtm!

@phieronymus
Copy link
Collaborator Author

I really need some vacation...

@gdp88
Copy link
Collaborator

gdp88 commented Dec 6, 2024

alright merging!

@gdp88 gdp88 merged commit 92e7279 into master Dec 6, 2024
6 checks passed
@gdp88 gdp88 deleted the feature/pierreh/add-three-ds-enable-and-disable branch December 6, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants