Allow body transfer encoding overrides #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phieronymus
commented
Feb 7, 2025
src/api/RestAPI.ts
Outdated
Comment on lines
269
to
270
| bodyTransferEncoding === "entity" | ||
| ? true && ![HTTPMethod.GET, HTTPMethod.HEAD].includes(method) |
There was a problem hiding this comment.
As per specification GET and HEAD can never have a payload.
There was a problem hiding this comment.
Do we need the true && part here? 🤔
phieronymus
commented
Feb 7, 2025
| ? true && ![HTTPMethod.GET, HTTPMethod.HEAD].includes(method) | ||
| : bodyTransferEncoding === "message" | ||
| ? false | ||
| : ![HTTPMethod.GET, HTTPMethod.HEAD, HTTPMethod.DELETE].includes(method); |
There was a problem hiding this comment.
Sneakily added HEAD in the default cases as it was missing.
YusukeFukushima
approved these changes
Feb 7, 2025
|
@YusukeFukushima Yeah. It is best not to use a body for the delete call method as it is not recommended. This if for customer who do not have the choice given their API. |
gdp88
approved these changes
Feb 7, 2025
src/api/RestAPI.ts
Outdated
| /** | ||
| * Overrides default body transfer encoding of the request. | ||
| * | ||
| * Note: Can not for for GET and HEAD request |
There was a problem hiding this comment.
Cannot and remove duplicate for?
src/api/RestAPI.ts
Outdated
Comment on lines
269
to
270
| bodyTransferEncoding === "entity" | ||
| ? true && ![HTTPMethod.GET, HTTPMethod.HEAD].includes(method) |
There was a problem hiding this comment.
Do we need the true && part here? 🤔
|
minor comments..lgtm! |
|
Indeed, the true was not necessary, thanks for catching this 🙂 |
|
thanx! merging! |
gdp88
deleted the
feature/pierreh/allow-body-transfer-encoding-override
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was asked for the services multiple time and backend was changed but it is only a matter of time before customer want to do the same as the web specifications allow for pretty wild usage.