Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix jsdoc #945

Merged
merged 1 commit into from
Jan 14, 2025
Merged

docs: fix jsdoc #945

merged 1 commit into from
Jan 14, 2025

Conversation

kanonji
Copy link
Contributor

@kanonji kanonji commented Jan 9, 2025

@kanonji kanonji requested a review from pi0 as a code owner January 9, 2025 19:58
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (a58d7c9) to head (31f8e35).
Report is 209 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
+ Coverage   77.83%   79.02%   +1.18%     
==========================================
  Files          47       43       -4     
  Lines        4286     3232    -1054     
  Branches      611      795     +184     
==========================================
- Hits         3336     2554     -782     
+ Misses        933      675     -258     
+ Partials       17        3      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nozomuikuta nozomuikuta changed the title docs: remove @property {boolean} internal that not exists docs: fix jsdoc Jan 14, 2025
Copy link
Member

@nozomuikuta nozomuikuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kanonji

Thank you for the PR!
It's appreciated if you submit another PR to v1 as well.

@nozomuikuta nozomuikuta merged commit fb480ec into unjs:main Jan 14, 2025
5 checks passed
@kanonji kanonji deleted the patch-1 branch January 14, 2025 12:32
@kanonji kanonji mentioned this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants