Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eval): return fallback value #326

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix(eval): return fallback value #326

merged 1 commit into from
Oct 7, 2024

Conversation

webpro
Copy link
Contributor

@webpro webpro commented Oct 7, 2024

Resolve #324 (comment).

Seems to do the trick. Let me if know if you'd need extra tests.

pi0
pi0 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(you can test with jiti-nightly after merge)

@pi0 pi0 changed the title Return fallback eval-ed module fix(eval): return fallback value Oct 7, 2024
@webpro
Copy link
Contributor Author

webpro commented Oct 7, 2024

(built, installed and tested with pnpm install ../jiti etc)

@pi0 pi0 merged commit dccce59 into unjs:main Oct 7, 2024
7 checks passed
@webpro webpro deleted the fix/issue-324 branch October 7, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression when require(extensionless-ts) from JS
2 participants
@webpro @pi0