Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudflare): make sure not fallback to globalThis for env #183

Merged
merged 4 commits into from
May 21, 2024
Merged

fix(cloudflare): make sure not fallback to globalThis for env #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12b07a6
feat(cloudflare): add global process polyfill to cloudflare preset
jculvey May 15, 2024
3468d3a
Addressing PR feedback
jculvey May 15, 2024
2eff838
Trim down cloudflare polyfill
jculvey May 16, 2024
47c64f8
Apply suggestions from code review
pi0 May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/presets/cloudflare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const cloudflarePreset: Preset = {
),
},
inject: {},
polyfill: [],
polyfill: ["unenv/runtime/polyfill/cloudflare"],
external: cloudflareNodeCompatModules.map((p) => `node:${p}`),
};

Expand Down
2 changes: 2 additions & 0 deletions src/runtime/polyfill/cloudflare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// Make sure env polyfill won't fallback to legacy `globalThis` used for service-worker format
(globalThis as any).__env__ = {};
pi0 marked this conversation as resolved.
Show resolved Hide resolved
pi0 marked this conversation as resolved.
Show resolved Hide resolved