Created a JSON output of site info for webaudit. Draft. Fixes #28. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28
I have some questions before merging
Instead of the d7 site ID, I am using the d10 site ID as the site/object identifier. As some sites do not have a D7 site ID. We would need to check how WebAudit processes that.
Currently, the path /admin/sites/unl/json-feed/ is only allowed for superadmins and administrators. What would be the best way for WebAudit to access it securely? Access tokens?
I have added code so it looks for and displays the primary base URL. If non exist, it will default to the site url found on unl_sites