Semi and pipe tokens (#6)

unmango · Jan 15, 2025 · a5a63f2 · a5a63f2
1 parent 16c6a5f
commit a5a63f2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/token/token.go b/token/token.go
@@ -32,7 +32,9 @@ const (
 	RBRACE  // }
 	DOLLAR  // $
 	COLON   // :
+	SEMI    // ;
 	COMMA   // ,
+	PIPE    // |
 	NEWLINE // \n
 	TAB     // \t
 
@@ -119,7 +121,9 @@ var tokens = [...]string{
 	RBRACE:  "}",
 	DOLLAR:  "$",
 	COLON:   ":",
+	SEMI:    ";",
 	COMMA:   ",",
+	PIPE:    "|",
 	NEWLINE: "\n",
 	TAB:     "\t",
 
@@ -279,7 +283,7 @@ func IsIdentifier(name string) bool {
 		return false
 	}
 	switch name {
-	case "(", ")", "{", "}", "$", ":", ",", "\n", "\t", "#":
+	case "(", ")", "{", "}", "$", ":", ";", ",", "\n", "\t", "|", "#":
 		fallthrough
 	case "=", ":=", "::=", ":::=", "?=", "!=":
 		return false

diff --git a/token/token_test.go b/token/token_test.go
@@ -508,11 +508,18 @@ var _ = Describe("Token", func() {
 			Entry(nil, "file"),
 			Entry(nil, "value"),
 			Entry(nil, ""),
+			func(keyword string) {
+				Expect(token.IsIdentifier(keyword)).To(BeFalse())
+			},
+		)
+
+		DescribeTable("special characters",
 			Entry(nil, "("),
 			Entry(nil, ")"),
 			Entry(nil, "{"),
 			Entry(nil, "}"),
 			Entry(nil, ":"),
+			Entry(nil, ";"),
 			Entry(nil, "$"),
 			Entry(nil, "#"),
 			Entry(nil, ","),
@@ -524,6 +531,7 @@ var _ = Describe("Token", func() {
 			Entry(nil, "\t"),
 			Entry(nil, "?="),
 			Entry(nil, "!="),
+			Entry(nil, "|"),
 			func(keyword string) {
 				Expect(token.IsIdentifier(keyword)).To(BeFalse())
 			},