Add Fprint #10
Merged
Add Fprint #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two new string methods have been added to the LiteralFileName and Ident nodes in the Abstract Syntax Tree (AST). These methods return the literal identifier of each node. Corresponding tests have also been added to ensure these new methods work as expected.
The print.go file has been updated to include the ability to print 'Recipe' and 'Rule' nodes. This includes writing the token, text, targets, prerequisites, and any associated recipes. Corresponding tests have also been added in print_test.go to ensure that these new functionalities work as expected.
Enhanced the test suite in print_test.go by adding a DescribeTable for surfacing errors. This includes multiple entries that simulate different error positions within the writing process of targets, prerequisites, and recipes. The new tests ensure that our package correctly handles and reports these errors.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 93.57% 94.20% +0.62%
==========================================
Files 7 8 +1
Lines 436 483 +47
==========================================
+ Hits 408 455 +47
Misses 21 21
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Added a new section in the README file explaining how to use `make.Fprint` for writing ast nodes. Also, adjusted the default target and threshold values under 'patch' in the codecov configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.