Adding Dockerfile support #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, but I'm not too knowledgable about Docker, so I should probably ask you. |
|
It does it all for you, so a user will just need to point 80/443 at the container to get this up and running. But yes, this builds/installs the app and runs it via nginx. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds Dockerfile support to build the application using a multi-stage build process.
- Introduces a builder stage based on composer/composer to install dependencies.
- Implements a final image based on trafex/php-nginx, adding php83-sodium via apk and copying application files.
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY . . |
There was a problem hiding this comment.
Consider using a .dockerignore file and more specific COPY instructions to ensure that only necessary files are included in the build context.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.