Stuff #119
Merged
Stuff #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 20, 2026 22:11
glob is for using the patterns
how did this happen
This changes it to use serde(with), since then checking the pattern for errors is done when the config is being parsed with no extra calls/remembering needed. And also general other stuff.
Collaborator
Author
|
(wrong branch) |
Collaborator
Author
|
(what was i smoking) |
This function is now useless
…into path_exclusions
Owner
|
Funnily enough, this seems to compile on MacOS (not sure about working as intended on mac yet) |
Owner
|
I won't review this just yet since its a draft |
added 8 commits
January 22, 2026 18:49
The splitting is really just moving the stuff for app finding somewhere else
The variable here will always be unused on windows
Mainly so that all the defs are somewhere other than the main business logic
I "kind of" accidentally used TSDoc syntax for docstrings
This uses the open crate instead of custom functions
added 5 commits
January 22, 2026 19:40
Too much noise for the main log file
It's fine if it's just unwrapped, since if it gets here, it's already been checked.
added 5 commits
January 23, 2026 19:45
dumb ass mistake
The syntax is <path>[:<depth>] for a specified depth, and if the depth specifier is ommited, the depth is 1. Also makes it put known folders in windows into the include key in the config by default, to keep everything in one place.
Removes the trailing slash for Local/AppData/Programs returned by get_known_paths.
Owner
|
can you try to fix the macos issues that have been highlighted in the workflow? |
Merged
Collaborator
Author
|
See #135 (i goofed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly adds path exclusion functionality (and also some random refractors since I suck at separating out that sort of thing).
Exactly 0 macos support, since I don't have any way to test that (it probably breaks a good amount of it)
(update: also a lot of refactors since)