Use skim for searching #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unsecretised
requested changes
Jan 26, 2026
Owner
There was a problem hiding this comment.
The name_lc field as used as an Alias so imo it should be present. Maybe you can add that field back with a different name like alias or smt. Additionally I will try out the changes locally. Additionally, i'm not sure if this is something that I would want to add, since personally i feel like its providing 70+ results for just "s", whereas before its only about 15 - 20...
Also searching for "settings" doesn't show rustcast settings, searching for "cas" shows everything related to rustcast before everything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves from a btree to using skim for searching