Windows support #35
Open
Windows support #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not need to create the file if it already exists...
not sure what I was doing there, but this should be correct
Brought back windows way to open google..
Now when we open the app via the shortcut it centers it and also make it appear on the right monitor (where mouse cursor is).
removed an used struct gotta keep things clean
on launch of the app, it would not center it nor take it to the right screen, now it does.
Start adding windows support
now compiles again on macos, it was mostly cfg stuff..
I fixed type annotation on Windows or it would not compile.
focuses the app when opened.
Windows support - don't kaboom macos compiling
Fix issues clippy highlighted
Cleaned up imports so they are at the top of the file, nothing serious just picky
we can now have customs paths to index and file exe's from, perhaps in the future we could accept globals in the array..
double imports RIP
styles was hidden behind a cfg macos for now reasons at all it seems handle_from_icns was returning errors on Windows (lol) for now it only returns None
Fixed LocalAppData searching everywhere, now looks in the Programs folder of LocalAppData also a little log because why not
it was once again only for macos,. it is now a black square on windows. because why not, and yeah.
Makes the file vv_log.log that also contains TRACE, while log.log just contains DEBUG and above. Done on mobile (and thus untested), so likely to be wrong
how tf did this happen
This is totally not an excercise in pointlessness
This reverts commit 9671165.
Generalised stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't be merged yet, but it should also be checked for breaking anything in the macos side.