Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing gui import error and adding some minor convenience #143

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

tobiglaser
Copy link
Contributor

Fixing onelab path setup so I can show this repo to my professor with the gui working out of the box.

  • gui is not a package and the script is in the same folder, so no prefix is needed.
  • Reenable the commented out argument and function call. This way the popup will appear if no femmt/config.json is found.
  • Change the default QTabs to the "Definition" rather then the empty "Simulation" tab.
  • Ignore the working directory to keep git status clean.

Copy link
Contributor

@gituser789 gituser789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@gituser789
Copy link
Contributor

easy fix needed, as ruff has been upgraded in the meantime. As we are waiting for new ruff features, we require always the latest version of it.

just do

pip install ruff

and run

ruff check $(git ls-files '*.py') --fix 

this should fix the three issues for the pipeline.

@gituser789 gituser789 merged commit 1fc23ff into upb-lea:main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants