Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare for v1 #6

Merged
merged 6 commits into from
Dec 6, 2024
Merged

prepare for v1 #6

merged 6 commits into from
Dec 6, 2024

Conversation

markandersontrocme
Copy link
Member

@markandersontrocme markandersontrocme commented Dec 6, 2024 •
edited
Loading

Description of your changes

  • Move to TS
  • use api-token
  • get latest current version if cached
  • small fixes

Fixes #5

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

@markandersontrocme markandersontrocme changed the title move to TS prepare for v1 Dec 6, 2024
@markandersontrocme markandersontrocme self-assigned this Dec 6, 2024
@markandersontrocme markandersontrocme marked this pull request as ready for review December 6, 2024 18:03
adamwg
adamwg requested changes Dec 6, 2024
View reviewed changes
Copy link
Member

@adamwg adamwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we should change in the current version check - otherwise, lgtm.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
adamwg
adamwg approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@adamwg adamwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@markandersontrocme markandersontrocme merged commit 53fe639 into main Dec 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwg adamwg adamwg approved these changes

Assignees

@markandersontrocme markandersontrocme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements to make it v1.0.0
2 participants
@markandersontrocme @adamwg