Skip to content

Conversation

haarchri
Copy link
Member

Description of your changes

  • todo
    add via CI as secret with:
        credentials:
        - name: claude
          source: Secret
          secretRef:
            namespace: crossplane-system
            name: claude
  • when running e2e tests - we need to update the cloud identity trust credentials in the test - that we using something like:

https://github.com/upbound/project-template-aws-s3/blob/main/.github/workflows/e2e.yaml#L36-L40
https://github.com/upbound/project-template-aws-s3/blob/main/.github/workflows/e2e.yaml#L64-L69
https://github.com/upbound/project-template-aws-s3/blob/main/template/tests/e2etest-xstoragebucket-kcl/main.k#L56-L61

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant