feat: enable ingress and upgrade arogcd #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
/test-examples |
|
@markandersontrocme can you rebase and run uptest again ? Thanks |
markandersontrocme
force-pushed
the
feat/enable-ingress
branch
from
0e32350 to
7788785
Compare
|
/test-examples |
ytsarev
reviewed
Jun 3, 2024
markandersontrocme
changed the title
|
/test-examples |
Comment on lines
-229
to
-230
| service: | ||
| type: LoadBalancer |
There was a problem hiding this comment.
This might be a breaking change to the current way this configuration is being used?
There was a problem hiding this comment.
yes let's add this as Release Notes - then it's fine
haarchri
reviewed
Jun 3, 2024
|
/test-examples |
haarchri
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes https://github.com/upbound/team-platform/issues/62
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested