Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(endpoint): switch to prod endpoint #3

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Nov 26, 2024

Description of your changes

switch to final endpoint

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
Copy link

upbound/project-template #3

Change Summary:

  • Updating the endpoint URL in CI workflow from private-cli.upbound.io to cli.upbound.io, suggesting a migration from a private to a public CLI endpoint

Potential Vulnerabilities:

  • File: .github/workflows/ci.yaml:21
  • Code: endpoint: https://cli.upbound.io
  • Explanation: Moving from a private to a public endpoint could potentially expose sensitive operations if the endpoint doesn't implement proper access controls. The security implications of this change should be carefully reviewed, especially since this involves CI/CD infrastructure.

Code Smells:

  • No significant code smells identified in this change.

Debug Logs:

  • No debug logs present in the changes.

Unintended Consequences:

  • File: .github/workflows/ci.yaml:21
  • Code: endpoint: https://cli.upbound.io
  • Explanation: This change could potentially break existing CI pipelines that depend on the private CLI endpoint. It's important to verify that:
    1. All required functionality is available in the public endpoint
    2. All necessary authentication mechanisms are in place
    3. Any rate limiting or quota differences between private and public endpoints are accounted for
    4. Other projects or dependencies aren't hardcoded to use the private endpoint

Risk Score: 7

This receives a relatively high risk score because:

  1. It modifies core CI/CD infrastructure
  2. Changes authentication endpoints
  3. Could potentially impact all downstream builds and deployments
  4. Represents a fundamental shift from private to public endpoint usage

@haarchri haarchri merged commit e104df9 into main Dec 10, 2024
1 check passed
@haarchri haarchri deleted the feature/switch-cli-endpoint branch December 10, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants