Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes): set kubernetes_ca_cert as sensitive #2

Closed
wants to merge 2 commits into from

Conversation

haarchri
Copy link
Member

Description of your changes

https://crossplane.slack.com/archives/C01TRKD4623/p1690290399596229

building a poc for managing vault config via crossplane, i m trying to deploy this https://marketplace.upbound.io/providers/upbound/provider-vault/v0.1.0/resources/kubernetes.vault.upbound.io/AuthBackendConfig/v1alpha1 resource and was wondering how can we specify spec.forProvider.kubernetesCaCert via a configmap/secret rather than raw values

switched kubernetesCaCert as sensitive - that its possible to set via kubernetes secret

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

create & delete

@mustafaStakater
Copy link

Can we add support for specifying kubernetes_ca_cert as configmap,
how long till this gets merged ? thanks

@haarchri
Copy link
Member Author

i checked our providers in crossplane-contrib/provider-aws and upbound/provider-aws both implementing ca_cert in connection secret so i see no need for configmap - and with upjet we have no option for both

haarchri added 2 commits July 31, 2023 14:27
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri haarchri force-pushed the feature/kubernetes-ca-cert branch from d0eedc1 to 18e28dc Compare July 31, 2023 12:30
@haarchri
Copy link
Member Author

rebased

@mustafaStakater
Copy link

mustafaStakater commented Jul 31, 2023

what todo if we want to use the kube-root-ca.crt configmap as kubernetes_ca_cert, possible when vault is running on the same cluster as crossplane

@haarchri
Copy link
Member Author

@mustafaStakater today we have not the option to have secret and configmap as ref

@haarchri haarchri closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants