fix(deps): k8s dependencies to v0.31.0 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Claim and Composite interface impls
avalanche123
approved these changes
Sep 24, 2024
| @@ -171,7 +162,6 @@ func GetComposition(cmp *extv1.Composition) Composition { | |||
| }, | |||
| WriteConnectionSecretsToNamespace: cmp.Spec.WriteConnectionSecretsToNamespace, | |||
| }, | |||
| Status: GetCompositionStatus(cmp.Status), | |||
There was a problem hiding this comment.
does this change the schema?
There was a problem hiding this comment.
Not sure. I did deploy these changes to prod and didn't see an issue 🤷
Comment on lines
+269
to
+275
| // SetObservedGeneration of this composite resource claim. | ||
| func (c *Composite) SetObservedGeneration(generation int64) { | ||
| status := &xpv1.ObservedStatus{} | ||
| _ = fieldpath.Pave(c.Object).GetValueInto("status", status) | ||
| status.SetObservedGeneration(generation) | ||
| _ = fieldpath.Pave(c.Object).SetValue("status.observedGeneration", status.ObservedGeneration) | ||
| } |
There was a problem hiding this comment.
not sure where this is used? is this related to the change in a schema object?
There was a problem hiding this comment.
This is because the Composition API changed and this function is expected now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
General dependency upgrade to try to get better memory efficiencies with JSON marshal/unmarshal.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Ran make test locally.