Skip to content

Commit

Permalink
add missing semicolons in tests
Browse files Browse the repository at this point in the history
The tests were loading File::Spec, but were missing the trailing
semicolons. This resulted in the return value from the open call being
passed in to File::Spec->import. Perl would then ignore that call to a
nonexistent import. Future versions of perl are intending to make calls
to undefined import methods with arguments an error.
  • Loading branch information
haarg authored and plicease committed Aug 27, 2023
1 parent 0d37c99 commit 075f102
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion t/anyevent_open3_simple__print.t
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ my $dir = tempdir( CLEANUP => 1 );
my $fh;
open($fh, '>', File::Spec->catfile($dir, 'child.pl'));
print $fh join "\n", "#!$^X",
'use File::Spec',
'use File::Spec;',
"open(\$out, '>', File::Spec->catfile('$dir', 'child.out'));",
'while(<STDIN>) {',
' print $out $_',
Expand Down
2 changes: 1 addition & 1 deletion t/anyevent_open3_simple__stdin.t
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ my $dir = tempdir( CLEANUP => 1 );
my $fh;
open($fh, '>', File::Spec->catfile($dir, 'child.pl'));
print $fh "#!$^X\n";
print $fh 'use File::Spec', "\n";
print $fh 'use File::Spec;', "\n";
print $fh "open(\$out, '>', File::Spec->catfile('$dir', 'child.out'));", "\n";
print $fh 'while(<STDIN>) {', "\n";
print $fh ' print $out $_', "\n";
Expand Down

0 comments on commit 075f102

Please sign in to comment.