Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update #212

Merged
merged 10 commits into from
Nov 8, 2023
Merged

Feature/update #212

merged 10 commits into from
Nov 8, 2023

Conversation

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (2ab664f) 85.99% compared to head (2c0bd40) 86.43%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #212      +/-   ##
============================================
+ Coverage     85.99%   86.43%   +0.44%     
- Complexity      947      972      +25     
============================================
  Files            71       75       +4     
  Lines          2528     2603      +75     
============================================
+ Hits           2174     2250      +76     
+ Misses          354      353       -1     
Files Coverage Δ
src/Apis/AddonsApi.php 92.00% <100.00%> (+1.75%) ⬆️
src/Configuration.php 100.00% <ø> (ø)
src/File/AppData/AbstractAwsLabels.php 100.00% <100.00%> (ø)
src/File/AppData/AwsModerationLabel.php 100.00% <100.00%> (ø)
src/File/AppData/AwsRecognitionLabels.php 100.00% <ø> (ø)
src/File/AppData/AwsRecognitionModerationData.php 100.00% <100.00%> (ø)
...rc/File/AppData/AwsRecognitionModerationLabels.php 100.00% <100.00%> (ø)
src/Group.php 95.23% <ø> (ø)
src/Serializer/WordsConverter.php 100.00% <100.00%> (ø)
src/Apis/ConversionApi.php 84.67% <75.00%> (-0.45%) ⬇️
... and 3 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrew72ru andrew72ru marked this pull request as draft November 5, 2023 09:10
@andrew72ru
Copy link
Collaborator Author

@rsedykh when I'm calling the labels recognition or moderation labels recognition, I'm getting the error:

Client error: `POST https://api.uploadcare.com/addons/aws_rekognition_detect_moderation_labels/execute/` resulted in a `403 Forbidden` response:
{"detail":"Add-On execution is disabled for current project"}

So I can't check whether it works on the library side.

@rsedykh
Copy link
Member

rsedykh commented Nov 5, 2023

"Add-On execution is disabled for current project"

I've invited you as a collaborator to a project where these limits are lifted.

@andrew72ru andrew72ru marked this pull request as ready for review November 5, 2023 10:49
@rsedykh rsedykh merged commit 6d60643 into master Nov 8, 2023
3 checks passed
@rsedykh rsedykh deleted the feature/update branch November 8, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants