For Uploadcare::ConversionApi added get_document_conversion_formats_info method to get the possible document conversion formats.
#145
Conversation
WalkthroughThe recent updates introduce a new method Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant UploadcareRails
participant UploadcareAPI
User->>UploadcareRails: Call get_document_conversion_formats_info
UploadcareRails->>UploadcareAPI: GET /conversion/formats/document/
UploadcareAPI-->>UploadcareRails: Return supported formats (e.g., jpg, avif, bmp, gif)
UploadcareRails-->>User: Return supported formats
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
spec/uploadcare/rails/api/rest/conversion_api_spec.rb (1)
Line range hint
17-109: The test forget_document_conversion_formats_infois well-implemented and covers the basic successful response scenario. Consider adding tests for edge cases, such as invalid UUIDs or API errors.Would you like me to help by adding these additional test cases?
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- CHANGELOG.md (1 hunks)
- lib/uploadcare/rails/api/rest/conversion_api.rb (1 hunks)
- spec/fixtures/vcr_cassettes/conversion_api_get_document_conversion_formats_info.yml (1 hunks)
- spec/uploadcare/rails/api/rest/conversion_api_spec.rb (2 hunks)
- uploadcare-rails.gemspec (1 hunks)
Files skipped from review due to trivial changes (1)
- uploadcare-rails.gemspec
Additional context used
LanguageTool
CHANGELOG.md
[duplication] ~13-~13: Possible typo: you repeated a word
Context: ...on formats. ## 3.4.2 — 2024-05-11 ### Added * Added API support for `AWS Rekognition Modera...
[style] ~55-~55: Consider using a different verb for a more formal wording.
Context: ... ## 3.3.2 — 2023-03-26 ### Changed * Fixed an issue with the configuration * Updat...
[style] ~102-~102: In American English, abbreviations like “etc.” require a period.
Context: ...s mime-type, image (dimensions, format, etc), video information (duration, format, ...
[style] ~102-~102: In American English, abbreviations like “etc.” require a period.
Context: ...information (duration, format, bitrate, etc), audio information, etc - Field `met...
[style] ~102-~102: In American English, abbreviations like “etc.” require a period.
Context: ...rmat, bitrate, etc), audio information, etc - Fieldmetadatathat includes arbi...
[style] ~108-~108: This phrase is redundant (‘I’ stands for ‘interface’). Use simply “API”.
Context: ...plications ### Added - Add Uploadcare API interface: -Uploadcare::FileMetadataApi- ...
[style] ~129-~129: This phrase is redundant (‘I’ stands for ‘interface’). Use simply “API”.
Context: ...with 1.x.* ### Added - Add Uploadcare API interface: - Uploadcare::FileApi - Uploadcare...
Markdownlint
CHANGELOG.md
88-88: Expected: asterisk; Actual: dash
Unordered list style
89-89: Expected: asterisk; Actual: dash
Unordered list style
90-90: Expected: asterisk; Actual: dash
Unordered list style
91-91: Expected: asterisk; Actual: dash
Unordered list style
92-92: Expected: asterisk; Actual: dash
Unordered list style
93-93: Expected: asterisk; Actual: dash
Unordered list style
94-94: Expected: asterisk; Actual: dash
Unordered list style
95-95: Expected: asterisk; Actual: dash
Unordered list style
96-96: Expected: asterisk; Actual: dash
Unordered list style
97-97: Expected: asterisk; Actual: dash
Unordered list style
101-101: Expected: asterisk; Actual: dash
Unordered list style
102-102: Expected: asterisk; Actual: dash
Unordered list style
103-103: Expected: asterisk; Actual: dash
Unordered list style
104-104: Expected: asterisk; Actual: dash
Unordered list style
108-108: Expected: asterisk; Actual: dash
Unordered list style
109-109: Expected: asterisk; Actual: dash
Unordered list style
110-110: Expected: asterisk; Actual: dash
Unordered list style
111-111: Expected: asterisk; Actual: dash
Unordered list style
112-112: Expected: asterisk; Actual: dash
Unordered list style
122-122: Expected: asterisk; Actual: dash
Unordered list style
129-129: Expected: asterisk; Actual: dash
Unordered list style
130-130: Expected: asterisk; Actual: dash
Unordered list style
131-131: Expected: asterisk; Actual: dash
Unordered list style
132-132: Expected: asterisk; Actual: dash
Unordered list style
133-133: Expected: asterisk; Actual: dash
Unordered list style
134-134: Expected: asterisk; Actual: dash
Unordered list style
135-135: Expected: asterisk; Actual: dash
Unordered list style
136-136: Expected: asterisk; Actual: dash
Unordered list style
137-137: Expected: asterisk; Actual: dash
Unordered list style
138-138: Expected: asterisk; Actual: dash
Unordered list style
142-142: Expected: asterisk; Actual: dash
Unordered list style
143-143: Expected: asterisk; Actual: dash
Unordered list style
144-144: Expected: asterisk; Actual: dash
Unordered list style
145-145: Expected: asterisk; Actual: dash
Unordered list style
146-146: Expected: asterisk; Actual: dash
Unordered list style
147-147: Expected: asterisk; Actual: dash
Unordered list style
149-149: Expected: asterisk; Actual: dash
Unordered list style
150-150: Expected: asterisk; Actual: dash
Unordered list style
151-151: Expected: asterisk; Actual: dash
Unordered list style
155-155: Expected: asterisk; Actual: dash
Unordered list style
156-156: Expected: asterisk; Actual: dash
Unordered list style
157-157: Expected: asterisk; Actual: dash
Unordered list style
158-158: Expected: asterisk; Actual: dash
Unordered list style
159-159: Expected: asterisk; Actual: dash
Unordered list style
160-160: Expected: asterisk; Actual: dash
Unordered list style
161-161: Expected: asterisk; Actual: dash
Unordered list style
162-162: Expected: asterisk; Actual: dash
Unordered list style
163-163: Expected: asterisk; Actual: dash
Unordered list style
164-164: Expected: asterisk; Actual: dash
Unordered list style
165-165: Expected: asterisk; Actual: dash
Unordered list style
169-169: Expected: asterisk; Actual: dash
Unordered list style
176-176: Expected: asterisk; Actual: dash
Unordered list style
180-180: Expected: asterisk; Actual: dash
Unordered list style
181-181: Expected: asterisk; Actual: dash
Unordered list style
186-186: Expected: asterisk; Actual: dash
Unordered list style
187-187: Expected: asterisk; Actual: dash
Unordered list style
190-190: Expected: asterisk; Actual: dash
Unordered list style
195-195: Expected: asterisk; Actual: dash
Unordered list style
196-196: Expected: asterisk; Actual: dash
Unordered list style
201-201: Expected: asterisk; Actual: dash
Unordered list style
202-202: Expected: asterisk; Actual: dash
Unordered list style
205-205: Expected: asterisk; Actual: dash
Unordered list style
206-206: Expected: asterisk; Actual: dash
Unordered list style
209-209: Expected: asterisk; Actual: dash
Unordered list style
210-210: Expected: asterisk; Actual: dash
Unordered list style
183-183: Expected: 1; Actual: 2
Multiple consecutive blank lines
192-192: Expected: 1; Actual: 2
Multiple consecutive blank lines
198-198: Expected: 1; Actual: 2
Multiple consecutive blank lines
1-1: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
13-13: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
114-114: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
115-115: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
119-119: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
120-120: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
124-124: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
125-125: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
167-167: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
168-168: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
168-168: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
173-173: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
174-174: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
178-178: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
179-179: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
179-179: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
184-184: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
185-185: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
185-185: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
189-189: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
193-193: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
194-194: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
194-194: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
199-199: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
200-200: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines
200-200: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
204-204: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
208-208: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines
14-14: null
Lists should be surrounded by blank lines
80-80: null
Lists should be surrounded by blank lines
169-169: null
Lists should be surrounded by blank lines
180-180: null
Lists should be surrounded by blank lines
186-186: null
Lists should be surrounded by blank lines
190-190: null
Lists should be surrounded by blank lines
195-195: null
Lists should be surrounded by blank lines
201-201: null
Lists should be surrounded by blank lines
205-205: null
Lists should be surrounded by blank lines
209-209: null
Lists should be surrounded by blank lines
37-37: null
Bare URL used
63-63: null
Bare URL used
Additional comments not posted (3)
lib/uploadcare/rails/api/rest/conversion_api.rb (1)
24-28: The implementation ofget_document_conversion_formats_infofollows the established pattern and correctly uses theDocumentConverter.infomethod. Ensure that error handling is robust in theDocumentConverter.infomethod.spec/fixtures/vcr_cassettes/conversion_api_get_document_conversion_formats_info.yml (1)
1-59: The VCR cassette forget_document_conversion_formats_infocorrectly captures the HTTP request and response. Ensure that the captured data remains relevant and update the cassette as needed when the API changes.CHANGELOG.md (1)
7-10: The changelog entry for the addition ofget_document_conversion_formats_infois clear and appropriately documented under the "Unreleased" section.
Description
For
Uploadcare::ConversionApiaddedget_document_conversion_formats_infomethod to get the possible document conversion formats.Checklist
Summary by CodeRabbit
New Features
Chores
uploadcare-rubydependency version from4.4.1to4.4.2.Tests
Style
specdirectory from theMetrics/ModuleLengthRuboCop rule.