test: Add unit tests for FilesCountExtractor #152
Conversation
WalkthroughA new test suite has been introduced for the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
spec/uploadcare/rails/services/files_count_extractor_spec.rb (2)
7-7: Consider removing or modifying the top-level subject to avoid confusion.A new subject is defined at line 7 but is not referenced. A second subject is introduced at line 10 for the
.callmethod. If the first subject is not used, removing it will clarify your tests.-describe Uploadcare::Rails::FilesCountExtractor, type: :service do - subject { described_class.call(cdn_url, regex) } + +describe Uploadcare::Rails::FilesCountExtractor, type: :service do
3-4: Adopt the RuboCop recommendation to use single-quoted strings.These lines are flagged by RuboCop for using double-quoted strings without interpolation or special characters. Adopting single quotes when unnecessary to use double quotes is a common Ruby style convention.
-require "spec_helper" -require "uploadcare/rails/services/files_count_extractor" +require 'spec_helper' +require 'uploadcare/rails/services/files_count_extractor' -context "when input_str is blank" do +context 'when input_str is blank' do -context "when input_str is present" do +context 'when input_str is present' do -context "when it doesn't contain `~` character" do +context 'when it does not contain `~` character' do -let(:input_str) { "foobar" } +let(:input_str) { 'foobar' } -it { is_expected.to eq "foobar" } +it { is_expected.to eq 'foobar' } -context "when it contains a `~` character" do +context 'when it contains a `~` character' do -let(:input_str) { "foo~bar" } +let(:input_str) { 'foo~bar' } -it { is_expected.to eq "bar" } +it { is_expected.to eq 'bar' }Also applies to: 12-13, 18-19, 20-21, 22-23, 25-26, 26-27, 28-29
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
spec/uploadcare/rails/services/files_count_extractor_spec.rb(1 hunks)
🧰 Additional context used
🪛 rubocop (1.69.1)
spec/uploadcare/rails/services/files_count_extractor_spec.rb
[convention] 9-9: Prefer single-quoted strings when you don't need string interpolation or special symbols.
(Style/StringLiterals)
[convention] 12-12: Prefer single-quoted strings when you don't need string interpolation or special symbols.
(Style/StringLiterals)
[convention] 18-18: Prefer single-quoted strings when you don't need string interpolation or special symbols.
(Style/StringLiterals)
[convention] 20-20: Prefer single-quoted strings when you don't need string interpolation or special symbols.
(Style/StringLiterals)
[convention] 22-22: Prefer single-quoted strings when you don't need string interpolation or special symbols.
(Style/StringLiterals)
[convention] 25-25: Prefer single-quoted strings when you don't need string interpolation or special symbols.
(Style/StringLiterals)
[convention] 26-26: Prefer single-quoted strings when you don't need string interpolation or special symbols.
(Style/StringLiterals)
[convention] 28-28: Prefer single-quoted strings when you don't need string interpolation or special symbols.
(Style/StringLiterals)
🔇 Additional comments (1)
spec/uploadcare/rails/services/files_count_extractor_spec.rb (1)
12-16: Add test coverage for empty string input.
We currently test nil, but it might be beneficial to include a scenario where input_str is "" (an empty string). This ensures clarity on the service’s response for all “blank” scenarios.
Would you like me to open an issue or propose a test snippet that covers this edge case?
🧰 Tools
🪛 rubocop (1.69.1)
[convention] 12-12: Prefer single-quoted strings when you don't need string interpolation or special symbols.
(Style/StringLiterals)
There were no tests covering FilesCountExtractor behavior. Changes here adds specs to cover the scenarios specified by it.
lidimayra
force-pushed
the
lidimayra/cover-files-count-extractor
branch
from
310b889 to
15e2d0d
Compare
Description
There were no tests covering FilesCountExtractor behavior.
Changes here adds specs to cover the scenarios specified by it.
Checklist
- [ ] Documentation (if applicable)Summary by CodeRabbit
FilesCountExtractorservice.