Add instruction to configure minikube #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add instruction to configure minikube. Add instruction and example to automate this addon for local development.
stevesloka
reviewed
Aug 17, 2018
| 2. Get the Replication Controller | ||
|
|
||
| ```bash | ||
| kubectl get rc registry-creds -o yaml -n kube-system --export > replicationController.yaml |
There was a problem hiding this comment.
We should probably update the examples to use deployments and not replication controllers.
There was a problem hiding this comment.
is it still valid, btw? I guess there is no any resource created by registry-creds as far as I can see. Is it true?
|
Thanks for the PR @ajfriesen! Could I ask that you help me update example to use deployments instead of RC's? Its just tech debt that we need to clean up as things have changed in k8s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instruction to configure minikube.
Add instruction and example to automate this addon for local development.