fontconfig: generate font cache in ${libdir}#181
Open
vishwasudupa wants to merge 1 commit intouptane:masterfrom
Open
fontconfig: generate font cache in ${libdir}#181vishwasudupa wants to merge 1 commit intouptane:masterfrom
vishwasudupa wants to merge 1 commit intouptane:masterfrom
Conversation
conf/distro/sota.conf.inc
Outdated
|
|
||
| # Postinst script in fontcache class will create cache | ||
| # at this path during do_rootfs | ||
| FONTCONFIG_CACHE_DIR:sota = "${libdir}/cache/fontconfig" |
Collaborator
There was a problem hiding this comment.
I belive the sota here is not required because the override will be crated in the sota.bbclass. Can you please test it without the :sota?
Collaborator
There was a problem hiding this comment.
Yeah, sota is not needed here.
Contributor
Author
There was a problem hiding this comment.
updated without sota and built successfully, updated in latest patch.
conf/distro/sota.conf.inc
Outdated
|
|
||
| # Postinst script in fontcache class will create cache | ||
| # at this path during do_rootfs | ||
| FONTCONFIG_CACHE_DIR:sota = "${libdir}/cache/fontconfig" |
Collaborator
There was a problem hiding this comment.
I belive the sota here is not required because the override will be crated in the sota.bbclass. Can you please test it without the :sota?
Contributor
Author
There was a problem hiding this comment.
yes tested without sota, it builds fine, updated in latest patch
The font cache is created using a postinstall step during do_rootfs
in ${localstatedir}/cache. Override default value to point to
${libdir}/cache via sota.conf.inc to globally use during do_rootfs.
Packaging generated ${libdir}/cache via bbappend
this helps to fix fontconfig OSTree‑related warnings.
Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
28d3c44 to
84cd505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The font cache is created using a postinstall step during do_rootfs in ${localstatedir}/cache. Override default value to point to ${libdir}/cache via sota.conf.inc to globally use during do_rootfs. Packaging generated ${libdir}/cache via bbappend
this helps to fix fontconfig OSTree‑related warnings.