Skip to content

Comments

fontconfig: generate font cache in ${libdir}#181

Open
vishwasudupa wants to merge 1 commit intouptane:masterfrom
vishwasudupa:fontconfig-sota
Open

fontconfig: generate font cache in ${libdir}#181
vishwasudupa wants to merge 1 commit intouptane:masterfrom
vishwasudupa:fontconfig-sota

Conversation

@vishwasudupa
Copy link
Contributor

The font cache is created using a postinstall step during do_rootfs in ${localstatedir}/cache. Override default value to point to ${libdir}/cache via sota.conf.inc to globally use during do_rootfs. Packaging generated ${libdir}/cache via bbappend
this helps to fix fontconfig OSTree‑related warnings.


# Postinst script in fontcache class will create cache
# at this path during do_rootfs
FONTCONFIG_CACHE_DIR:sota = "${libdir}/cache/fontconfig"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive the sota here is not required because the override will be crated in the sota.bbclass. Can you please test it without the :sota?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sota is not needed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated without sota and built successfully, updated in latest patch.


# Postinst script in fontcache class will create cache
# at this path during do_rootfs
FONTCONFIG_CACHE_DIR:sota = "${libdir}/cache/fontconfig"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive the sota here is not required because the override will be crated in the sota.bbclass. Can you please test it without the :sota?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes tested without sota, it builds fine, updated in latest patch

The font cache is created using a postinstall step during do_rootfs
in ${localstatedir}/cache. Override default value to point to
${libdir}/cache via sota.conf.inc to globally use during do_rootfs.
Packaging generated ${libdir}/cache via bbappend
this helps to fix fontconfig OSTree‑related warnings.

Signed-off-by: Vishwas Udupa <vudupa@qti.qualcomm.com>
Copy link
Collaborator

@quaresmajose quaresmajose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants