Use main ci for building docker images #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdesouky
force-pushed
the
dev-878/modify-ci-workflow-to-push-docker-images-to-two-repos
branch
from
a7db0f1 to
edbec1d
Compare
uptickmetachu
previously approved these changes
Oct 24, 2024
.github/workflows/publish.yml
Outdated
| @@ -15,38 +15,24 @@ permissions: | |||
| env: | |||
| MISE_PYTHON_COMPILE: false | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| AWS_IAM_ROLE: "" | |||
| @@ -24,3 +24,19 @@ jobs: | |||
| command: | | |||
| mise run install | |||
| mise run ci | |||
| build: | |||
There was a problem hiding this comment.
We can remove this now no?
There was a problem hiding this comment.
@uptickmetachu we don't want test builds ?
There was a problem hiding this comment.
I guess if we have the lifecycle policies.
I don't think its entirely too neccessary but it doesn't hurt too much.
uptickmetachu
approved these changes
Oct 24, 2024
mdesouky
deleted the
dev-878/modify-ci-workflow-to-push-docker-images-to-two-repos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
cireusable github actions workflow