Folder in init wollok init [folder]
#190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmigueles
commented
Sep 21, 2024
| @@ -39,7 +39,7 @@ export type FileContent = { | |||
|
|
|||
| export const createFolderIfNotExists = (folder: string): void => { | |||
| if (!existsSync(folder)) { | |||
| mkdirSync(folder) | |||
| mkdirSync(folder, { recursive: true }) | |||
There was a problem hiding this comment.
Capaz lo puedo pasar por parametro esto
PalumboN
approved these changes
Sep 22, 2024
| @@ -39,7 +39,7 @@ export type FileContent = { | |||
|
|
|||
| export const createFolderIfNotExists = (folder: string): void => { | |||
| if (!existsSync(folder)) { | |||
| mkdirSync(folder) | |||
| mkdirSync(folder, { recursive: true }) | |||
Comment on lines
+19
to
31
| export const pathAssertions: Chai.ChaiPlugin = (chai) => { | ||
| const { Assertion } = chai | ||
|
|
||
| Assertion.addMethod('pathExists', function (path) { | ||
| const exists = existsSync(path) | ||
| this.assert( | ||
| exists, | ||
| 'expected path #{this} to exist', | ||
| 'expected path #{this} to not exist', | ||
| path | ||
| ) | ||
| }) | ||
| } |
There was a problem hiding this comment.
Me fallaba y me decia expected true, but false o algo asi, con esto dice el path exacto del archivo que falla, una belleza
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #189
Now the init command has an optional argument for the folder name.
Known issue
Me esta creando la carpeta
logpor fuera y no veo donde se crea