fix(deps): Remove unused cap dependency #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Looks like this is just the example package.json, is it causing issues if you install it from NPM? Just trying to figure out how urgent a release is |
|
Looks like its just validation from my other issue, going to merge and wait on the release. Thanks again! |
|
It’s the example app, no no need for a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
It removes the dependency to cap
Why are these changes necessary?
looks like it was added by mistake and prevents
npm installfrom installing on my computer and it's not being usedHow did you verify these changes?
I verified that
npm installworks fine after removing that dependency andnpm run buildkeeps workingVerification Screenshots:
Anything else a reviewer should know?