Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null for some optional fields #273

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Allow null for some optional fields #273

merged 1 commit into from
Jun 24, 2024

Conversation

vtnate
Copy link
Collaborator

@vtnate vtnate commented Mar 25, 2024

Resolves #271

Pull Request Description

Also allow null for a few more optional fields.

The internal UI was generating invalid geojson files, because null wasn't allowed in the schema. Now it's ok.

Checklist (Delete lines that don't apply)

  • Unit tests have been added or updated
  • Documentation has been modified appropriately
  • All ci tests pass (green)
  • An issue has been created (which will be used for the changelog)
  • This branch is up-to-date with develop

@vtnate vtnate added the bug Something isn't working label Mar 25, 2024
@vtnate vtnate self-assigned this Mar 25, 2024
@vtnate vtnate requested a review from kflemin March 25, 2024 20:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8426375989

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.31%

Totals Coverage Status
Change from base Build 7470718795: 0.0%
Covered Lines: 805
Relevant Lines: 922

💛 - Coveralls

@vtnate vtnate merged commit adcaf19 into develop Jun 24, 2024
1 check passed
@vtnate vtnate deleted the schema-additions branch June 24, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UO UI defaults fail schema validation
3 participants