Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline nixjs-rt #109

Merged
merged 2 commits into from
Mar 23, 2024
Merged

inline nixjs-rt #109

merged 2 commits into from
Mar 23, 2024

Conversation

urbas
Copy link
Owner

@urbas urbas commented Mar 22, 2024

This change inlines nixjs-rt.

The development workflow is described in the top CONTRIBUTE.md file.

cc @arduano

@arduano
Copy link
Collaborator

arduano commented Mar 22, 2024

Just looked through, looks about right. In the future, it might be good to make a command that runs all the watchers in parallel in an ergonomic way, rather than using 3-4 shells.

Also, I assume we can begin migrating the tests after this right? To have more concise tests that directly use rix, rather than the boilerplate heavy tests in js.

@urbas
Copy link
Owner Author

urbas commented Mar 23, 2024

Just looked through, looks about right. In the future, it might be good to make a command that runs all the watchers in parallel in an ergonomic way, rather than using 3-4 shells.

Yes, a single command sounds good, but the trick will likely be to make its output easy to understand. In any case, it would be good to think further on how to make this project easier to develop.

Also, I assume we can begin migrating the tests after this right? To have more concise tests that directly use rix, rather than the boilerplate heavy tests in js.

Yes, We can probably just delete the tests in JS and only have them in Rust.

@urbas urbas merged commit a6c74bd into master Mar 23, 2024
2 checks passed
@urbas urbas deleted the inline-nixjs-rt branch March 23, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants