Skip to content

Comments

Бабич Людмила#28

Open
Ludmilishee wants to merge 5 commits intourfu-2016:masterfrom
Ludmilishee:master
Open

Бабич Людмила#28
Ludmilishee wants to merge 5 commits intourfu-2016:masterfrom
Ludmilishee:master

Conversation

@Ludmilishee
Copy link

@Ludmilishee Ludmilishee commented Nov 7, 2016 •
edited by honest-hrundel
Loading

@honest-hrundel
Copy link

honest-hrundel commented Nov 7, 2016

🍅 Не пройден линтинг или базовые тесты

@honest-hrundel
Copy link

honest-hrundel commented Nov 7, 2016

🍅 Не пройден линтинг или базовые тесты

@honest-hrundel
Copy link

honest-hrundel commented Nov 7, 2016

🍅 Не пройден линтинг или базовые тесты

@honest-hrundel
Copy link

honest-hrundel commented Nov 7, 2016

🍅 Не пройден линтинг или базовые тесты

@honest-hrundel
Copy link

honest-hrundel commented Nov 7, 2016

🍏 Пройден линтинг и базовые тесты

Dodo888
Dodo888 reviewed Nov 8, 2016
View reviewed changes
index.html
</head>
<body>
<input type="checkbox" class="output-switch">
<p>Включить отображение списком</p>
Copy link

@Dodo888 Dodo888 Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ Больше похоже на label, чем на p

index.html
<body>
<input type="checkbox" class="output-switch">
<p>Включить отображение списком</p>
<div class="cat">
Copy link

@Dodo888 Dodo888 Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ article

index.html
<img src="images/cat_01.jpg" alt="Мурзик">
</div>
<div class="cat-details">
<nav class="name-effect">
Copy link

@Dodo888 Dodo888 Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ Тег навигации обычно используется в навигации или меню)

index.html
</div>
<div class="cat-details">
<nav class="name-effect">
<p>
Copy link

@Dodo888 Dodo888 Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ Зачем ссылки оборачивать в p?

index.html
<input id="star1-0.5" type="radio" title="poor">
<label class="left-star" for="star1-0.5"></label>
</div>
<div class="price">
Copy link

@Dodo888 Dodo888 Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ Внутри каждого товара можно информацию ещё на секции побить)

index.css
{
padding-right: 20%;
display: inline-block;
*zoom: 1;
Copy link

@Dodo888 Dodo888 Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется, невалидное правило

index.css
-webkit-box-shadow: 4px 4px 4px rgba(0,0,0,.2);
-moz-box-shadow: 4px 4px 4px rgba(0,0,0,.2);
box-shadow: 4px 4px 4px rgba(0,0,0,.2);
-webkit-transition: all .5s ease-out;
Copy link

@Dodo888 Dodo888 Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ Почему на вебките другая функция перемещения?

index.css
box-shadow: 4px 4px 4px rgba(0,0,0,.2);
-webkit-transition: all .5s ease-out;
-moz-transition: all .5s ease;
-o-transition: all .5s ease;
Copy link

@Dodo888 Dodo888 Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ Обязательно указывать соответствующие правила без вендорных префиксов, даже если им никто не пользуется

index.css
text-align: left;
overflow: hidden;
text-overflow: ellipsis;
color: dimgrey;
Copy link

@Dodo888 Dodo888 Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ Лучше указывать цвета в hex

index.css
{
background-position: 0 0;
height: 37px;
width: 19px;
Copy link

@Dodo888 Dodo888 Nov 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 за спрайты

@Dodo888
Copy link

Dodo888 commented Nov 8, 2016

❗️ Более низкая оценка не ставится, если уже была поставлена более высокая

@Dodo888
Copy link

Dodo888 commented Nov 8, 2016

❗️ Разное поведение в разных браузерах
Chrome:
image
Edge и Firefox:
image

@Dodo888
Copy link

Dodo888 commented Nov 8, 2016

🚀

@honest-hrundel honest-hrundel assigned mokhov and unassigned Dodo888 Nov 8, 2016
@mokhov
Copy link
Contributor

mokhov commented Nov 10, 2016

Жду правок от Вовы

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Dodo888 Dodo888 Dodo888 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mokhov mokhov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ludmilishee @honest-hrundel @Dodo888 @mokhov