Open
Conversation
mokhov
requested changes
May 16, 2017
mokhov
left a comment
mokhov
left a comment
There was a problem hiding this comment.
Хорошо, но может быть лучше и аккуратнее
formatDate.js
Outdated
| // Напишите код форматирования даты в этом месте | ||
| const moths = ['января', 'февраля', 'марта', 'апреля', 'мая', 'июня', 'июля', 'августа', 'сентября', 'октября', 'ноября', 'декабря'] | ||
|
|
||
| function formatDate(date1) { |
formatDate.js
Outdated
| else | ||
| var hours = date.getUTCHours(); | ||
| if (date.getUTCMinutes() < 10) | ||
| var minutes = '0' + date.getUTCMinutes(); |
formatDate.js
Outdated
| return 'вчера в '+ hours + ':' + minutes; | ||
| } | ||
| if (date.getFullYear() < curYear) | ||
| return date.getUTCDate() + ' ' + moths[date.getUTCMonth()] + ' ' + date.getFullYear() + ' года в ' + hours + ':'+ minutes; |
There was a problem hiding this comment.
Вызовы .getUTC* можно закэшировать в переменную
|
|
||
|
|
||
|
|
||
| it ('should throw error when arguments number is 0', () =>{ |
There was a problem hiding this comment.
Нет проверки что аргументов не может быть больше 1
tests/formatDate-test.js
Outdated
| assert.equal(actual, "31 января 2000 года в 11:59"); | ||
| }); | ||
|
|
||
| it('should return `31 декабря 1999 года в 23:59` for `1999-12-31T10:59:59.999Z`', () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.