Open
Conversation
|
🍏 Пройден линтинг и базовые тесты |
|
"Также от вас требуется: Обрезать длинные имена котиков (=^ ◡ ^=) |
Xrias
requested changes
Nov 2, 2018
Xrias
left a comment
Xrias
left a comment
There was a problem hiding this comment.
За Салема жирный лойс и за бутер тоже.
| </header> | ||
| <article> | ||
| <div class="image_container"> | ||
| <img alt="salem" src="https://cdn5.img.ria.ru/images/148839/96/1488399690.jpg"> |
| <label for="view" class="hamburger">☰</label> | ||
| </header> | ||
| <article> | ||
| <div class="image_container"> |
There was a problem hiding this comment.
А почему этот див это див, а не section? Давай поменяем.
| @@ -0,0 +1,98 @@ | |||
| header | |||
There was a problem hiding this comment.
Всем тегам давай дадим классы, тегов в css остаться не должно.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Посмотреть решение