Merge pull request #341 from FormidableLabs/323-fix-serialization-of-…

…default-obj-args Add stringification of default input arguments
urql-graphql · Mar 18, 2021 · 87b6ac8 · 87b6ac8
2 parents 51d29fa + 65c7534
commit 87b6ac8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/panel/__image_snapshots__/Schema - basic-landscape-snap.png b/src/panel/__image_snapshots__/Schema - basic-landscape-snap.png
diff --git a/src/panel/pages/request/components/Fields.tsx b/src/panel/pages/request/components/Fields.tsx
@@ -32,11 +32,10 @@ export const Fields: FC<FieldProps> = ({ node, setType }) => {
       <Deprecated>{`Deprecated: ${field.deprecationReason}`}</Deprecated>
     ) : null;
 
-  const getDefaultValue = (field: GraphQLInputField | GraphQLArgument) => {
-    return field.defaultValue !== undefined || null ? (
-      <Default>{` = ${field.defaultValue}`}</Default>
+  const getDefaultValue = (field: GraphQLInputField | GraphQLArgument) =>
+    field.defaultValue !== undefined || null ? (
+      <Default>{` = ${JSON.stringify(field.defaultValue)}`}</Default>
     ) : null;
-  };
 
   const getDescription = (
     field:

diff --git a/src/panel/pages/request/components/Schema.fixture.tsx b/src/panel/pages/request/components/Schema.fixture.tsx
@@ -48,6 +48,10 @@ type Query {
   threads(sortBy: SortBy!, skip: Int = 0, limit: Int): [Thread!]!
   thread(id: ID!): Thread
   me: User
+  """
+  Test with object for default args
+  """
+  specificThread(thread: ThreadInput! = { title: "Test", text: "Hello" }): [Thread!]!
 }
 
 "Reply to a post, this is a little longer description"