Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch image model #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yholkamp
Copy link

This PR updates the image model to Include the image_data as allowed property and updates the relationship target to prefer to use the data over the configured URL. Added a test to assert that the image_data value is set as expected. The base64 string contains a pink PNG pixel.

This solves #131

…to use the data over the configured URL, added test to assert the image_data is set
@yholkamp yholkamp requested a review from jdugan February 8, 2020 19:29
goulvench added a commit to goulvench/caracal that referenced this pull request Mar 18, 2020
Fix issue urvin-compliance#131 (img tag URL is resolved even when data is provided)
@adamreisnz
Copy link

I'm guessing this isn't going to get merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants