Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create-score-version Github Action #2194

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

travis-newby
Copy link
Collaborator

@travis-newby travis-newby commented Mar 8, 2023

This PR updates the create-score-version Github Action to,

  • Separate the action into a few logical steps, and organize the action around those logical steps. This fixes a potential issue where the backend score could be deployed then fail a smoke test, resulting in no tiles being built or uploaded.
  • Use the test input option to upload everything to a new test folder and run smoke tests from there. That way we can test this script without deploying version 1.0 again.
  • Separate out the "extra" uploaded files (from data_pipeline/files) to be in their own folder, and name that folder data_pipeline/files/static to indicate that these files don't change (often). Files in this folder will get automatically uploaded during the build process.

Organize create-score-version around logical steps, add ability to test more easily, and update files to be in their own folder unique to the version being deployed
Copy link
Collaborator

@vim-usds vim-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started and improving the flow! Wrote up a few ideas on ways to potentially improve. Let's discuss :)

.github/workflows/create-score-version.yml Outdated Show resolved Hide resolved
.github/workflows/create-score-version.yml Show resolved Hide resolved
.github/workflows/create-score-version.yml Outdated Show resolved Hide resolved
…tic files for the sake of the build, and update score version (and constants) to use that directory
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Score Comparison Summary

Hi! I'm the Score Comparator. I compared the score in production (version 1.0) to the locally calculated score. Here are the results.

Columns

I compared the columns. Here's what I found.

  • There are no differences in the column names.

Scores

I compared the scores, too. Here's what I found.

  • The production score has 74,134 census tracts, and the freshly calculated score has 74,134. They match!
  • The total population in all census tracts in the production score is 328,267,709.0. The total population in all census tracts locally is 328,267,709.0. They match!
  • There are 27,248 disadvantaged tracts in the production score representing 33.3% of the total population, and 27,248 in the locally generated score representing 33.3% of the total population. The number of tracts match!
  • There are 0 tract(s) marked as disadvantaged in the production score that are not disadvantaged in the locally generated score (i.e. disadvantaged tracts that were removed by the new score). There are 0 tract(s) marked as disadvantaged in the locally generated score that are not disadvantaged in the production score (i.e. disadvantaged tracts that were added by the new score).
  • I compared all values across all census tracts. There are 0 tracts with at least one difference. Please examine the logs or run the score comparison locally to view them all.

@vim-usds
Copy link
Collaborator

vim-usds commented Mar 10, 2023

@travis-newby - I don't believe the cache invalidation is in the script. We could place it in another ticket if you think that's better.

Just set this up here.

As an FYI, the BE distribution ID is E1324VDMNCO97N. All other env vars would be the same as above.

Copy link
Collaborator

@vim-usds vim-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vim-usds
Copy link
Collaborator

Also a fast follow will be to update the FE links once these files are on S3 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update create-score-version github action to upload files to S3 for beta version only
2 participants