Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate dylint lints to build #1412

Merged
merged 35 commits into from
Jan 24, 2024
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
b1a4d65
feat(build): Always execute dylint-based lints
jubnzv Nov 17, 2023
f736546
feat(build): Don't check `cargo` output since we have a lint for this
jubnzv Nov 21, 2023
ddabef6
chore(build): cleanup
jubnzv Nov 27, 2023
7946de2
feat: Implement `extra_lints`
jubnzv Dec 23, 2023
f2cb3de
feat: Pass on-chain build options for the linter
jubnzv Dec 23, 2023
8f392c4
chore: fmt+clippy
jubnzv Dec 23, 2023
d74f7ca
fix: Unneeded steps when executing `cargo`
jubnzv Dec 23, 2023
1d15601
feat: Print more context on error when running `cargo`
jubnzv Dec 23, 2023
83df3fb
chore: Bump changelog
jubnzv Dec 23, 2023
d197c76
Merge remote-tracking branch 'origin/master' into mandatory-lints
jubnzv Dec 23, 2023
8950df2
feat: Install `cargo-dylint` and `dylint-link` in CI
jubnzv Dec 23, 2023
577fa72
fix(ci): Install missing packages in `template` section
jubnzv Dec 23, 2023
b3cbec9
fix(readme): Mark the `dylint` installation step as mandatory
jubnzv Dec 23, 2023
f21e2b8
feat(docker): Add `dylint` installation to the docker image
jubnzv Dec 23, 2023
8b7c7f3
Merge remote-tracking branch 'origin/master' into mandatory-lints
jubnzv Jan 3, 2024
c7a0626
Merge remote-tracking branch 'origin/master' into mandatory-lints
jubnzv Jan 15, 2024
af380eb
fix(ci): Install linting dependencies
jubnzv Jan 15, 2024
6c4be8d
fix(ci): deps
jubnzv Jan 15, 2024
9fb5222
fix: Install dependencies
jubnzv Jan 15, 2024
4a22459
fix(build): Fix installation for `ink_linting` libraries
jubnzv Jan 19, 2024
a97de2f
chore: Add rust-toolchain.toml
jubnzv Jan 19, 2024
557a696
fix(ci): Use rust-toolchain.toml from the repo
jubnzv Jan 19, 2024
45c531f
fix(ci): Toolchain version
jubnzv Jan 19, 2024
823dac9
fix(ci): Try to run it with the nightly toolchain
jubnzv Jan 19, 2024
3d4af86
fix(ci): Force `stable` toolchain for the `clippy` action
jubnzv Jan 19, 2024
84780ba
fix(tests): Failing test
jubnzv Jan 19, 2024
01dd588
fix(readme)
jubnzv Jan 20, 2024
44cf7b1
fix(ci): Use the `nightly` toolchain for template builds
jubnzv Jan 20, 2024
38c8bcd
chore: Remove the fixed toolchain version
jubnzv Jan 23, 2024
f3212f3
feat(build): Make `dylint` mandatory only for RiscV or `--lint`
jubnzv Jan 23, 2024
284f0ff
feat(build): Check `ink_linting` toolchain
jubnzv Jan 23, 2024
df89a75
fix: `cargo-dylint` test
jubnzv Jan 23, 2024
789087c
fix(ci): Remove `dylint` installation
jubnzv Jan 23, 2024
169da84
fix(test): Run only on mandatory lints which are disabled
jubnzv Jan 23, 2024
a86c38b
fix(test): Fix to check for non-existing toolchain
jubnzv Jan 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(ci): deps
  • Loading branch information
jubnzv committed Jan 15, 2024
commit 6c4be8ddfaee4691e10df3c68dba96f4287acabf
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -143,7 +143,7 @@ jobs:

# Required to run mandatory lints in `cargo contract build` tests
- name: Install linting dependencies
run: cargo install cargo-dylint dylint-link ink_linting_mandatory ink_linting
run: cargo install cargo-dylint dylint-link ink_linting_mandatory

- name: Cache
uses: Swatinem/rust-cache@v2
@@ -191,7 +191,7 @@ jobs:

# Required to run mandatory lints in `cargo contract build`
- name: Install cargo-dylint and dylint-link
run: cargo install cargo-dylint dylint-link
run: cargo install cargo-dylint dylint-link ink_linting_mandatory

- name: Cache
uses: Swatinem/rust-cache@v2
Loading