fix: fix balance subrow issue to show /granted always#780
Open
charlietlamb wants to merge 3 commits intomainfrom
Open
fix: fix balance subrow issue to show /granted always#780charlietlamb wants to merge 3 commits intomainfrom
charlietlamb wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Tip New to Tusk? Learn more here. |
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 3/5
- The allowance calculation in
vite/src/views/customers2/components/table/customer-balance/CustomerBalanceTableColumns.tsxalways usesent.adjustment, so sub-rows with anentityIdmay display incorrect per-entity adjustments. - Given the mid-severity logic issue (5/10) in a customer balance view, there’s some risk of user-facing calculation inaccuracies even if the change is localized.
- Pay close attention to
vite/src/views/customers2/components/table/customer-balance/CustomerBalanceTableColumns.tsx- ensure sub-row adjustments use the entity-specific value whenentityIdis present.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="vite/src/views/customers2/components/table/customer-balance/CustomerBalanceTableColumns.tsx">
<violation number="1" location="vite/src/views/customers2/components/table/customer-balance/CustomerBalanceTableColumns.tsx:70">
P2: Use entity-specific adjustments for sub-rows; the current allowance calculation always uses `ent.adjustment`, which ignores per-entity adjustments when `entityId` is provided.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
vite/src/views/customers2/components/table/customer-balance/CustomerBalanceTableColumns.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Contributor
Author
|
@cubic-dev-ai review |
Contributor
@charlietlamb I have started the AI code review. It will take a few minutes to complete. |
Contributor
Author
|
@cubic-dev-ai review |
Contributor
@charlietlamb I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes balance sub-rows so “/granted” always shows the full granted amount, and fixes sub-row expand/collapse by using stable row IDs.
Written for commit cd77f45. Summary will update on new commits.
Greptile Summary
Fixed balance calculation in customer balance table sub-rows to properly display granted allowances by including adjustments and prepaid quantities.
Key Changes
getIndividualEntValuesfunction to includeadjustmentandcusEntToPrepaidQuantityin allowance calculation, ensuring sub-rows display/grantedvalues consistently with parent rowscusEntToPrepaidQuantityutility function from@autumn/sharedThe change aligns the sub-row allowance calculation with the parent row logic used in
useFeatureUsageBalancehook, which callscusEntsToGrantedBalance(includes adjustments) and adds prepaid quantities. This ensures that manual adjustments and prepaid purchases are properly reflected in the balance display for individual entitlements.Confidence Score: 5/5
useFeatureUsageBalancehook andcusEntsToGrantedBalancefunction. No logical errors, syntax issues, or security concerns identified.Important Files Changed
Last reviewed commit: f0248b9