🔧 split filter_needs func by needs type

[chrisjsewell]

This makes it clearer what representation of needs we are trying to filter (see #1264).

The idea is that eventually we might be able to analyse the filter string and perform "short-circuit" filters,
for example, if it is id == "abc" and filter_needs_view, then all we actually need to perform is an O(1) lookup of the mapping, rather than perform an O(N) iteration over all the needs.

This then begins to address #1219.

[codecov]

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.91%. Comparing base (4e10030) to head (b09375f).
Report is 44 commits behind head on master.

Files with missing lines	Patch %	Lines
sphinx_needs/functions/common.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
+ Coverage   86.87%   86.91%   +0.03%     
==========================================
  Files          56       60       +4     
  Lines        6532     6932     +400     
==========================================
+ Hits         5675     6025     +350     
- Misses        857      907      +50     

Flag	Coverage Δ
pytests	86.91% <96.55%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ubmarco]

Approved with a comment

[ubmarco]

need to deprecate the old name?

[chrisjsewell]

I think no, because this is not part of the public api (i.e. https://sphinx-needs.readthedocs.io/en/latest/api.html), and anyhow it will force people to stop using it if they were 😅

[chrisjsewell]

(in principle we should change almost every module to have an _, but eurgh that would be annoying 😅