✨ Add get_needs_view
function to public API
#1277
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to access to the (immutable) resolved needs during the write/analysis phase (for example https://github.com/useblocks/sphinx-modeling, cc @ubmarco, also see #1264 for more info)
To ensure it is not misused, checks are now put in-place to disallow modification of needs after the needs have been resolved.
This actually surfaced a few issues where the resolved needs were mistakenly accessed, instead of the unresolved (mutable) ones.
The other reason for doing this, is that if we "know" we are only accessing immutable needs, then we will be able to improve filtering performance, by performing lazy indexing etc (see #1281)