Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Remove unused configuration variables #1303

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

chrisjsewell
Copy link
Member

Remove defined configuration variables that are not used anywhere in the codebase. I guess these are legacy configurations that were used once but no more.

Remove defined configuration variables that are not used anywhere in the codebase.
I guess these are legacy configurations that were used once but no more.
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.91%. Comparing base (4e10030) to head (30f6971).
Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
sphinx_needs/config.py 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
+ Coverage   86.87%   86.91%   +0.03%     
==========================================
  Files          56       60       +4     
  Lines        6532     6946     +414     
==========================================
+ Hits         5675     6037     +362     
- Misses        857      909      +52     
Flag Coverage Δ
pytests 86.91% <97.43%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell merged commit d25bd33 into master Sep 16, 2024
17 checks passed
@chrisjsewell chrisjsewell deleted the remove-legacy-config branch September 16, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants