Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added config allow unsafe filter for filter_func #949

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Added config allow unsafe filter for filter_func #949

merged 5 commits into from
Aug 3, 2023

Conversation

haiyangToAI
Copy link
Contributor

fix #831

ubmarco
ubmarco requested changes Jul 19, 2023
View reviewed changes
docs/configuration.rst Outdated Show resolved Hide resolved
@ubmarco ubmarco self-requested a review July 20, 2023 08:15
ubmarco
ubmarco approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@ubmarco ubmarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@danwos danwos merged commit ea10e03 into master Aug 3, 2023
11 checks passed
@danwos danwos deleted the allow_dirty_filter_for_filter_function branch August 3, 2023 15:39
nhatnamnguyengtvthcm pushed a commit to nhatnamnguyengtvthcm/sphinx-needs that referenced this pull request Aug 21, 2023
@haiyangToAI @danwos @nhatnamnguyengtvthcm
Added config allow unsafe filter for filter_func (useblocks#949)
e969347 
* Added config allow unsafe filter for filter_func

* Fixed review

* Updated sphinx-immaterial to fix CI

* Fix linkcheck anchor issue

---------

Co-authored-by: Daniel Woste <daniel.woste@useblocks.com>
nhatnamnguyengtvthcm pushed a commit to nhatnamnguyengtvthcm/sphinx-needs that referenced this pull request Aug 22, 2023
@haiyangToAI @danwos @nhatnamnguyengtvthcm
Added config allow unsafe filter for filter_func (useblocks#949)
4f5d185 
* Added config allow unsafe filter for filter_func

* Fixed review

* Updated sphinx-immaterial to fix CI

* Fix linkcheck anchor issue

---------

Co-authored-by: Daniel Woste <daniel.woste@useblocks.com>
nhatnamnguyengtvthcm pushed a commit to nhatnamnguyengtvthcm/sphinx-needs that referenced this pull request Aug 22, 2023
@haiyangToAI @danwos @nhatnamnguyengtvthcm
Added config allow unsafe filter for filter_func (useblocks#949)
d336da8 
* Added config allow unsafe filter for filter_func

* Fixed review

* Updated sphinx-immaterial to fix CI

* Fix linkcheck anchor issue

---------

Co-authored-by: Daniel Woste <daniel.woste@useblocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubmarco ubmarco ubmarco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow "dirty" filter results for filter functions
3 participants
@haiyangToAI @ubmarco @danwos