Add RPM linux build target #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunohpaiva
commented
Oct 11, 2023
There was a problem hiding this comment.
The whole file was changed as a result of the pre-commit hook "husky". The only change here was actually the addition of 'rpm' to the linux.target array.
|
Running on Fedora 38, installed via the RPM file
|
|
Thanks @brunohpaiva :) ! |
|
I see that https://github.com/usebruno/bruno/releases/tag/v0.24.0 was released yesterday but the RPM files are not present. Not a big deal as I can still use the AppImage file, but I assume the plan is to create RPMs for releases as well, right? |
|
Yes @rombert Will add support for downloading rpm files and eventually support for |
|
I had no issues with a local build on Fedora 38 from the main branch: git clone https://github.com/usebruno/bruno.git
cd bruno
npm install
npm run build:electron:rpm
cd packages/bruno-electron/out
dnf install bruno_0.24.0_x86_64_linux.rpm |
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds RPM as a Linux target to the electron-builder config.
The output is a
bruno_%version%_x86_64_linux.rpmfile in thepackages/bruno-electron/outdirectory.Resolves #230.