Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Updates Go to 1.23 #97

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Chore: Updates Go to 1.23 #97

merged 3 commits into from
Jan 30, 2025

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Jan 2, 2025

Updates Go to 1.23

closes #96

@CGoodwin90 CGoodwin90 marked this pull request as ready for review January 2, 2025 01:06
Dockerfile Outdated Show resolved Hide resolved
@shreddedbacon
Copy link
Member

I don't think this can't be merged yet. It doesn't build locally in its current form due to some changes, but the lacking tests locally makes it hard to verify. See #100

@shreddedbacon
Copy link
Member

Just rebased after #100 was merged so we get the github action test coverage

@shreddedbacon
Copy link
Member

I'm fine with this if you are too @bomoko

@bomoko
Copy link
Contributor

bomoko commented Jan 30, 2025

Yes @shreddedbacon , happy happy. I'll merge tomorrow

Copy link
Contributor

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bomoko bomoko merged commit 28d60ca into main Jan 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to golang 1.23
3 participants