Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Adds last used to the ssh keys table #300

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Change: Adds last used to the ssh keys table #300

merged 3 commits into from
Nov 12, 2024

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Oct 3, 2024 •
edited
Loading

Adds the last used timeframe to the SSH Keys table, and updates both created & last used to follow a similar format to Github.

sshupdate

sshtooltip

Closes #298

@CGoodwin90 CGoodwin90 marked this pull request as ready for review October 3, 2024 23:21
@shreddedbacon
Copy link
Member

I wonder if its worth having a tooltip that can show the actual date too? Then created could be the same? Thoughts?

@CGoodwin90
Copy link
Contributor Author

I wonder if its worth having a tooltip that can show the actual date too? Then created could be the same? Thoughts?

Is something like this what you were thinking for the combined created/last used?

combined

combined-tooltip

@shreddedbacon
Copy link
Member

Yeah! Probably don't need the divider between them though?
image

@shreddedbacon
Copy link
Member

image
Would it be worth left aligning these?

@shreddedbacon
Copy link
Member

Looks good now

tobybellwood
tobybellwood approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and adds great value!

@tobybellwood tobybellwood merged commit 2e0c5e8 into main Nov 12, 2024
4 checks passed
@tobybellwood tobybellwood deleted the last-used-sshkeys branch November 12, 2024 23:02
@tobybellwood tobybellwood restored the last-used-sshkeys branch November 12, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Dashboard - view the last used date of SSH keys
3 participants
@CGoodwin90 @shreddedbacon @tobybellwood